Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub templates #184

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Dec 22, 2022

Summary

This PR updates the GitHub issue and pull request templates.

Details

Issue templates are a bit verbose and could use some simplification.

There were references in the bug report to OS, browser, etc. which are not really applicable to WP_Mock, etc.

Pull requests could use a reviewer checklist which includes references to the updated CI workflow.

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
    • no documentation changes
  • I have added tests to cover changes introduced by this pull request
    • no code change
  • All new and existing tests pass

Testing

This PR has no code changes.

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Dec 22, 2022
@unfulvio-godaddy unfulvio-godaddy requested a review from a team December 22, 2022 07:54
@coveralls
Copy link

coveralls commented Dec 22, 2022

Coverage Status

Coverage remained the same at 11.201% when pulling 8157238 on chore/update-github-templates into bcfabe0 on trunk.

@unfulvio-godaddy unfulvio-godaddy added this to the 0.6.0 milestone Dec 22, 2022
Copy link
Contributor

@agibson-godaddy agibson-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! 🙌

@agibson-godaddy agibson-godaddy merged commit 6a227ea into trunk Dec 22, 2022
@agibson-godaddy agibson-godaddy deleted the chore/update-github-templates branch December 22, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants