Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused .gitmodules file #185

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Remove unused .gitmodules file #185

merged 2 commits into from
Dec 22, 2022

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Dec 22, 2022 •
edited by agibson-godaddy
Loading

Summary

This PR removes the git modules files which is currently unused by this project.

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
    • no documentation changes
  • I have added tests to cover changes introduced by this pull request
    • no code change
  • All new and existing tests pass

Testing

This PR has no code changes.

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Dec 22, 2022
@unfulvio-godaddy unfulvio-godaddy requested a review from a team December 22, 2022 08:10
@coveralls
Copy link

coveralls commented Dec 22, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 11.201% when pulling 30df1a0 on chore/remove-unused-git-modules into 6a227ea on trunk.

@unfulvio-godaddy unfulvio-godaddy added this to the 0.6.0 milestone Dec 22, 2022
@agibson-godaddy agibson-godaddy merged commit 8b1abb6 into trunk Dec 22, 2022
@agibson-godaddy agibson-godaddy deleted the chore/remove-unused-git-modules branch December 22, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agibson-godaddy agibson-godaddy agibson-godaddy approved these changes

Assignees

@unfulvio-godaddy unfulvio-godaddy

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@unfulvio-godaddy @coveralls @agibson-godaddy