Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestCase tests and split TestCase mock methods into trait #197

Merged
merged 13 commits into from
Jan 6, 2023
Merged

Add TestCase tests and split TestCase mock methods into trait #197

merged 13 commits into from
Jan 6, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jan 5, 2023 •
edited by agibson-godaddy
Loading

Summary

This PR adds several test cases for the TestCase class. Also splits some methods mocking WordPress objects into own trait.

Details

Other than splitting those mocking methods into a trait, there is no logic code change, although the TestCase has methods rearranged.

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

  • PHPUnit tests pass

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jan 5, 2023
@coveralls
Copy link

coveralls commented Jan 5, 2023 •
edited
Loading

Coverage Status

Coverage: 36.749% (+18.4%) from 18.331% when pulling 695f3e1 on chore/add-more-unit-tests into 4ea29a9 on trunk.

@unfulvio-godaddy unfulvio-godaddy requested a review from a team January 5, 2023 10:08
@unfulvio-godaddy unfulvio-godaddy added the Tests Updates to tests label Jan 5, 2023
ajaynes-godaddy
ajaynes-godaddy approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@ajaynes-godaddy ajaynes-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good here. Definitely a lot of churn in TestCase.php so it's a little hard to follow but I see the now-deprecated methods and everything seems in order.

@unfulvio-godaddy unfulvio-godaddy requested review from a team and removed request for a team January 6, 2023 06:41
@agibson-godaddy agibson-godaddy merged commit a73581a into trunk Jan 6, 2023
@agibson-godaddy agibson-godaddy deleted the chore/add-more-unit-tests branch January 6, 2023 12:43
@jeffpaul jeffpaul added this to the 0.6.0 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agibson-godaddy agibson-godaddy agibson-godaddy approved these changes

@ajaynes-godaddy ajaynes-godaddy ajaynes-godaddy approved these changes

Assignees

@unfulvio-godaddy unfulvio-godaddy

Labels
Tests Updates to tests
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@unfulvio-godaddy @coveralls @agibson-godaddy @ajaynes-godaddy @jeffpaul