Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gitbook.yaml to .gitbook.yaml #202

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jan 13, 2023

Summary

#201 added gitbook.yaml but this was intended to be a dot file .gitbook.yaml - my bad for not noticing this: currently this file does nothing because it's not parsed by GitBook until it has the correct format.

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

#201 added gitbook.yaml but this was intended to be a dot file .gitbook.yaml - my bad for not noticing this
currently this file does nothing because it's not parsed by GitBook until it has the correct format.
@coveralls
Copy link

Coverage Status

Coverage: 36.749%. Remained the same when pulling 8b0edda on chore/rename-gitbook-file into 2d3b0fc on trunk.

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jan 13, 2023
@unfulvio-godaddy unfulvio-godaddy added the Documentation Updates to documentation label Jan 13, 2023
@agibson-godaddy agibson-godaddy merged commit 9355ebf into trunk Jan 13, 2023
@agibson-godaddy agibson-godaddy deleted the chore/rename-gitbook-file branch January 13, 2023 12:25
@jeffpaul jeffpaul added this to the 0.6.0 milestone Jun 23, 2023
@unfulvio-godaddy unfulvio-godaddy removed this from the 0.6.0 milestone Jun 26, 2023
@unfulvio-godaddy
Copy link
Member Author

unfulvio-godaddy commented Jun 26, 2023

@jeffpaul this wasn't added to a milestone because documentation isn't part of a release, and changes are/were instant, so it didn't belong to a release

@jeffpaul jeffpaul added this to the v1.0.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants