Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes file to exclude dirs from archives #211

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Apr 24, 2023

Summary

Adds a .gitattributes file to add an exclusion list of files and dirs that are not necessary in distributable archives - this would make a distributable version of the package shipped via Composer smaller.

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy requested a review from a team April 24, 2023 07:58
@unfulvio-godaddy unfulvio-godaddy self-assigned this Apr 24, 2023
@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Coverage Status

Coverage: 43.396%. Remained the same when pulling 0420ca5 on chore/add-gitattributes into 0a34621 on trunk.

Copy link
Contributor

@agibson-godaddy agibson-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. One of the unit tests failed though but I'm not sure why.

@unfulvio-godaddy
Copy link
Member Author

@agibson-godaddy PHP 7.3 tests are failing because of this issue #212 TLDR the ubuntu image with PHP 7.3 is no longer supported in GitHub we need to change our workflow and install PHP directly -- thanks for reviewing!

@unfulvio-godaddy unfulvio-godaddy merged commit 8961bda into trunk Jun 2, 2023
@unfulvio-godaddy unfulvio-godaddy deleted the chore/add-gitattributes branch June 2, 2023 01:34
@jeffpaul jeffpaul added this to the 0.6.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants