Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and PhpStan return types #216

Merged
merged 15 commits into from
Jul 5, 2023
Merged

Update dependencies and PhpStan return types #216

merged 15 commits into from
Jul 5, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jun 20, 2023 •
edited
Loading

Summary

This PR updates some dependencies and documented return types that seem causing trouble with PhpStan.

Details

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jun 20, 2023
@coveralls
Copy link

coveralls commented Jun 20, 2023 •
edited
Loading

Coverage Status

coverage: 59.707% (-0.1%) from 59.84% when pulling 2a22e44 on update-dependencies into aad7f54 on trunk.

@unfulvio-godaddy unfulvio-godaddy marked this pull request as ready for review June 20, 2023 07:56
@unfulvio-godaddy unfulvio-godaddy requested a review from a team June 20, 2023 09:06
@unfulvio-godaddy unfulvio-godaddy changed the title Update dependencies Update dependencies and PhpStan return types Jun 20, 2023
@jeffpaul jeffpaul added this to the 0.6.0 milestone Jun 23, 2023
@unfulvio-godaddy unfulvio-godaddy mentioned this pull request Jun 29, 2023
Merged
9 tasks
@unfulvio-godaddy unfulvio-godaddy added the Dependencies Items related to Composer dependencies label Jun 30, 2023
@unfulvio-godaddy unfulvio-godaddy merged commit 3124ae7 into trunk Jul 5, 2023
6 checks passed
@unfulvio-godaddy unfulvio-godaddy deleted the update-dependencies branch July 5, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agibson-godaddy agibson-godaddy agibson-godaddy approved these changes

Assignees

@unfulvio-godaddy unfulvio-godaddy

Labels
Dependencies Items related to Composer dependencies
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@unfulvio-godaddy @coveralls @agibson-godaddy @jeffpaul