Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from WP_Mock main class #221

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jun 29, 2023

Summary

This PR removes a couple of deprecated methods from WP_Mock main class. These methods have been logging deprecation notices for a long time now and in preparation for v1.0.0 it's time to remove them.

Details

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy requested a review from a team June 29, 2023 10:17
@unfulvio-godaddy unfulvio-godaddy self-assigned this Jun 29, 2023
@coveralls
Copy link

coveralls commented Jun 29, 2023

Coverage Status

coverage: 60.322% (+0.6%) from 59.707% when pulling 46ea2d2 on chore/remove-deprecated-methods-for-v1 into 3124ae7 on trunk.

@unfulvio-godaddy unfulvio-godaddy changed the title Remove deprecated methods Remove deprecated methods from WP_Mock main class Jun 29, 2023
@unfulvio-godaddy unfulvio-godaddy added this to the v1.0.0 milestone Jun 30, 2023
agibson-godaddy
agibson-godaddy previously approved these changes Jul 4, 2023
@nmolham-godaddy nmolham-godaddy merged commit 7934d33 into trunk Jul 5, 2023
@nmolham-godaddy nmolham-godaddy deleted the chore/remove-deprecated-methods-for-v1 branch July 5, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants