Update return type for mockPost() #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The return type must be a
WP_Postand a mockery mock at the same time. I believe that the method needs to use an intersection type instead of an union one.Details
Unfortunately,
WP_Postcannot be used in an intersection type, because the class is declared as final (related discussions in PHPStan's repo). The current version ofmockPost()was always returningMockery\LegacyMockInterfaceso I think it still makes sense to update the return type.I also updated the return type of
mockWp()to return an intersection ofWPand Mockery mock interfaces. SinceWPis not final, we can use the intersection type directly.Contributor checklist
Reviewer checklist