Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify type of $args parameter #227

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

wvega-godaddy
Copy link
Contributor

Summary

Modifies the type of the $args parameter to be mixed[]. The array of arguments is unlikely to have string keys. mixed[] allows both positional and associative arrays as the list of arguments.

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@wvega-godaddy wvega-godaddy self-assigned this Jul 19, 2023
@coveralls
Copy link

Coverage Status

coverage: 65.646% (+0.1%) from 65.513% when pulling 8895d9a on chore/update-type-of-args-parameter into 23f0a46 on trunk.

@wvega-godaddy wvega-godaddy marked this pull request as ready for review July 20, 2023 02:35
@unfulvio-godaddy unfulvio-godaddy merged commit db23b60 into trunk Jul 20, 2023
6 checks passed
@unfulvio-godaddy unfulvio-godaddy deleted the chore/update-type-of-args-parameter branch July 20, 2023 05:14
@unfulvio-godaddy unfulvio-godaddy added this to the v1.0.0 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants