Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP Dependencies and run tests with PHP 8.3 #237

Merged
merged 12 commits into from
Jan 4, 2024
Merged

Update PHP Dependencies and run tests with PHP 8.3 #237

merged 12 commits into from
Jan 4, 2024

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Dec 27, 2023 •
edited
Loading

Summary

Updates PHP dev dependencies (patch versions) and PHP in composer to support PHP < 9.

This PR will also add a CI workflow to run tests in PHP 8.3.

Closes: #236

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

  • Unit tests pass with PHP 8.3 and previous PHP versions

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

After merge

  • Tag v1.0.1

@unfulvio-godaddy unfulvio-godaddy self-assigned this Dec 27, 2023
@unfulvio-godaddy unfulvio-godaddy requested a review from a team December 27, 2023 04:38
@unfulvio-godaddy unfulvio-godaddy added the Dependencies Items related to Composer dependencies label Dec 27, 2023
@coveralls
Copy link

coveralls commented Dec 27, 2023 •
edited
Loading

Coverage Status

coverage: 66.312%. remained the same
when pulling c52a4d3 on chore/update-php-req-to-support-v8.3
into e9e421c on trunk.

@unfulvio-godaddy unfulvio-godaddy mentioned this pull request Dec 27, 2023
Open
@unfulvio-godaddy unfulvio-godaddy changed the title Update PHP Dependencies Update PHP Dependencies and run tests with PHP 8.3 Dec 27, 2023
nmolham-godaddy
nmolham-godaddy approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@nmolham-godaddy nmolham-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmolham-godaddy nmolham-godaddy merged commit 4249c87 into trunk Jan 4, 2024
8 checks passed
@nmolham-godaddy nmolham-godaddy deleted the chore/update-php-req-to-support-v8.3 branch January 4, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmolham-godaddy nmolham-godaddy nmolham-godaddy approved these changes

Assignees

@unfulvio-godaddy unfulvio-godaddy

Labels
Dependencies Items related to Composer dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatability with PHP 8.3
3 participants
@unfulvio-godaddy @coveralls @nmolham-godaddy