Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a strict mode #75

Merged
merged 22 commits into from
Oct 31, 2016
Merged

Add a strict mode #75

merged 22 commits into from
Oct 31, 2016

Conversation

johnpbloch
Copy link
Contributor

This is intended to resolve #11.

@johnpbloch
Add a method to indicate strict mode
5b1916e
@johnpbloch
Reformat test
e5072fa
@johnpbloch
Add a method to activate strict mode
7e268fa
@johnpbloch
Strict mode should only be activated prior to bootstrap
156b4c4
@johnpbloch
If strict mode is on, throw an exception for undefined uses in the Ha…
c7e182b 
…ndler

class
@johnpbloch
Reformat behat test fixtures
c11f5b9
@johnpbloch
Add a test for strict mode forcing failure for sloppy use
ee60f74
@johnpbloch
Reformat some yaml
4a0fd9a
@johnpbloch
Add a test to make sure defined but unexpected tests don't fail in re…
e0e718f 
…gular mode
@johnpbloch
Move strict mode controls into the feature context class
7667de0
@johnpbloch
Add tests for unexpected action/filters in strict mode
598aec3
@johnpbloch
Make forceStrictModeOff always turn strict mode off
3005bb5
@johnpbloch
Actions fail on add_action() when strict mode is on and there's no co…
e332cce 
…rresponding expectation
@johnpbloch
Reformat some code
0a0cde3
@johnpbloch
Move strict_check() into HookedCallback
1eab201
@johnpbloch
Improve add_action/filter strict error message
5f7f176
@johnpbloch
Move some methods around to make better reuse of code
fe7fd42
@johnpbloch
Reformat
8649cb3
@johnpbloch
Add a strict check to do_action()
5f2260c
@johnpbloch
Add a strict check for unexpected uses of apply_filters()
c85bd66
@johnpbloch
Add documentation for strict mode to the readme
e0d080f 
Fixes #11
@johnpbloch
For internal tests, require phpunit 4.0+
8568683 
We still support 3.7+ for end-user application, but internally, our tests for the suite itself requires 4.0+
stevegrunwell
stevegrunwell approved these changes Oct 31, 2016
View reviewed changes
Copy link
Contributor

@stevegrunwell stevegrunwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnpbloch,

This is looking fantastic, though I wish GitHub featured an easy "no, seriously, ignore whitespace changes" option.

@johnpbloch
Copy link
Contributor Author

@stevegrunwell adding w=1 to the url query string will ignore whitespace. Not easy, but at least effective. :D

@johnpbloch johnpbloch merged commit 98fe07d into dev Oct 31, 2016
@ericmann ericmann deleted the feature/strict-mode branch May 27, 2017 04:31
@jeffpaul jeffpaul added this to the 0.2.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevegrunwell stevegrunwell stevegrunwell approved these changes

Assignees

@stevegrunwell stevegrunwell

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnpbloch @stevegrunwell @jeffpaul