Improve Dynamic Slugs documentation. #1489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve description of how Dynamic Slugs to Subset Your Pagination works. See: 11ty/eleventy#2544 It wasn't clear (to me) that you have to use an `Object` for your pagination data. Typically a CMS will return an array rather than an object and that produces weird results.
zachleat
reviewed
Feb 10, 2023
| 1. Via `pagination.alias`, your template now has access to `author.name` and `author.content` for `"zachleat"` | ||
| 1. And as `pagination.size` is set to 1, the pagination only operates on that one selected page for rendering. | ||
|
|
||
| {% callout "info", "md" %}You have to use an object for your pagination data. If you use an array you will get unexpected results.{% endcallout %} |
There was a problem hiding this comment.
Is this line true? You can’t use /authors/0/ to fetch [{ name: "", … }]?
There was a problem hiding this comment.
I think so.
If your posts object is an array, you can use /authors/0/ to fetch the first post, but that probably isn't very helpful.
You almost certainly want to match a serverless url against a full slug name and not just a numeric value.
Working repo here:
https://github.com/dwkns/eleventy-serverless-demo
zachleat
added
the
open-question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve description of how Dynamic Slugs to Subset Your Pagination works. See: 11ty/eleventy#2544
It wasn't clear (to me) that you have to use an
Objectfor your pagination data. Typically a CMS will return an array rather than an object and that produces weird results.