Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes shutdown process asynchronous and graceful #85

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

VividVisions
Copy link
Contributor

As proposed in #84:

  • EleventyDevServer.close() is now async and awaits all underlying close() methods.
  • It also prevents multiple invocations (due to multiple SIGINTs).
  • It also closes any existing WebSocket connections, since this doesn't happen automatically (see WS docs).
  • Cliand Cmd handle the now async close().
  • All tests also handle async close().

@zachleat zachleat added this to the Eleventy Dev Server v2.0.2 milestone Jul 30, 2024
@zachleat
Copy link
Member

Shipping with Dev Server v2.0.2, thank you!

(and core 3.0.0-alpha.18)

@zachleat zachleat merged commit 5878059 into 11ty:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants