Watch process doesn’t successfully close (3.0.0-alpha.17)

[paulrobertlloyd]

Operating system

macOS Sonoma 14.5

Eleventy

3.0.0-alpha.17

Describe the bug

Since 3.0.0-alpha.17, its not possible to stop the Eleventy process midway through a build, instead it either:

• appears to close (returned to the terminal prompt) but then new output messages are shown in terminal
• closes but throws an error

The result is that, as I develop locally, and start/stop builds, I’m ending up with many processes running (such that just testing this again now I’m serving my site from port 8087)

It would appear that this.watcher is undefined in

eleventy/src/Eleventy.js

Line 1196 in ff6338f

await this.watcher?.close();

Which is odd as this call uses optional chaining.

Likely related to the change in #3361

Reproduction steps

Error shown after stopping a process mid build:

Original error stack trace: TypeError: Cannot read properties of undefined (reading 'close')
     at Eleventy.stopWatch (file:///Users/paulrobertlloyd/Sites/paulrobertlloyd-v4/node_modules/@11ty/eleventy/src/Eleventy.js:1196:22)
     at async process.<anonymous> (/Users/paulrobertlloyd/Sites/paulrobertlloyd-v4/node_modules/@11ty/eleventy/cmd.cjs:120:9)

Expected behavior

Previous behaviour; felt much more robust than it does currently.

[zachleat]

Yeah, await this.watcher?.close(); was added 4 days ago, after 3.0.0-alpha.17. It’ll roll with 3.0.0-alpha.18: 6f36fe8