fix silent crashes in 11ty #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the build process MUST be reported to the user for diagnosis.
GerHobbelt
added a commit
to GerHobbelt/eleventy
that referenced
this pull request
Apr 8, 2020
…ct. The crux is the `throw eex;` rethrow statement in there: it SHOULD have caused an error report and aborted 11ty run, but no such luck without pullreq 11ty#1079
This was referenced Apr 8, 2020
Open
|
If someone can tell me what causes the crash I'll write a test that confirms this. Also correct me if wrong but the best way to deal with this might be to put a catch on |
|
See #1080: I did that one back then to showcase the crash. |
|
Yeah we can’t |
|
Pushed something similar to this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix silent crashes in 11ty: any failures with fatal consequences for the build process MUST be reported to the user for diagnosis.
Fixes #1081.