replace index.d.ts with jsdoc @typedef
#3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m on board with this but I do want a quick check from #3291’s author @chriskirknielsen—does this look okay? |
|
All I did was restore somebody else's work, so I don't think I have a say — but this change does look easier as it locates it all in a single file (and I like using JSDoc syntax), so if it matters, I'm on board, too! 😄 |
|
Thank you! Shipping with v3.0.0-alpha.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically reverts the changes from #3291 (and #2091), in favor of the approach from #3060.
A new JSDoc
@typedefcomment ensures thatUserConfigtypes are available (fixes #3097), and that everything exported fromEleventy.jshas proper types (fixes #2935).