Add support for the tracecontext standard #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bram123
commented
Dec 10, 2023
bram123
commented
- new traceMode config option to switch between traceid and tracecontext
- supporting both options at the same time is out of scope for this PR, might be possible in the future
- Need to think about what happens when X-TraceId header is in the request with a value that's not valid for traceContext standard, but app is doing ajax calls with traceparent headers.
- new traceMode config option to switch between traceid and tracecontext -- supporting both options at the same time is out of scope for this PR, might be possible in the future -- Need to think about what happens when X-TraceId header is in the request with a value that's not valid for traceContext standard, but app is doing ajax calls with traceparent headers.
frankdekker
reviewed
Dec 11, 2023
frankdekker
reviewed
Dec 11, 2023
frankdekker
reviewed
Dec 11, 2023
frankdekker
reviewed
Dec 11, 2023
# Conflicts: # README.md # phpmd.baseline.xml # phpstan-baseline.neon # src/DependencyInjection/Compiler/HttpClientTraceIdPass.php # src/DependencyInjection/SymfonyTraceExtension.php # src/EventSubscriber/CommandSubscriber.php # src/EventSubscriber/MessageBusSubscriber.php # src/EventSubscriber/TraceIdSubscriber.php # src/Generator/TraceId/RamseyUuid4Generator.php # src/Generator/TraceId/SymfonyUuid4Generator.php # src/Generator/TraceId/TraceIdGeneratorInterface.php # src/Http/TraceIdAwareHttpClient.php # src/Monolog/TraceIdProcessor.php # src/Twig/TraceIdExtension.php # tests/Functional/App/Service/TestIdStorage.php # tests/Functional/App/TestKernel.php # tests/Functional/App/config/config.yml # tests/Functional/ApplicationTest.php # tests/Functional/HttpClientTest.php # tests/Functional/MessengerTest.php # tests/Functional/RequestHandleTest.php # tests/Unit/EventSubscriber/CommandSubscriberTest.php # tests/Unit/EventSubscriber/MessageBusSubscriberTest.php # tests/Unit/EventSubscriber/TraceIdSubscriberTest.php # tests/Unit/Generator/TraceId/RamseyUuid4GeneratorTest.php # tests/Unit/Generator/TraceId/SymfonyUuid4GeneratorTest.php # tests/Unit/Http/TraceIdAwareHttpClientTest.php # tests/Unit/Monolog/TraceIdProcessorTest.php # tests/Unit/TraceStorageTest.php # tests/Unit/Twig/TraceIdExtensionTest.php
…arate Trace Service classes - split TraceContextService parse logic into separate Parse class
MessageBusSubscriber now passes the full TraceContext object to the TraceStamp - clones original TraceContext, fills parentTransactionId in cloned trace
Update baseline
frankdekker
reviewed
Dec 12, 2023
frankdekker
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.