Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only load necessary services based on tracemode #19

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Only load necessary services based on tracemode #19

merged 2 commits into from
Dec 18, 2023

Conversation

frankdekker
Copy link
Member

@frankdekker frankdekker commented Dec 18, 2023 •
edited
Loading

  • Organized the service configuration in separate methods.
  • Split off the service that are specific for a trace mode.
  • Added addDefaultsIfNotSet to http_client so the isset is no longer required.

@frankdekker frankdekker marked this pull request as ready for review December 18, 2023 21:17
@frankdekker frankdekker merged commit 7fc0677 into master Dec 18, 2023
14 checks passed
@frankdekker frankdekker deleted the Only-load-necessary-services-based-on-tracemode branch December 18, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bram123 bram123 bram123 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankdekker @bram123