[WIP] Add markdown extension, update jekyll plugin documentation #1986
Conversation
| super options.merge(config_options) | ||
| end | ||
|
|
||
| def header(title, level) |
There was a problem hiding this comment.
Method has too many lines. [11/10]
| @@ -1,65 +0,0 @@ | |||
| module Jekyll | |||
There was a problem hiding this comment.
@gboone this doesn't appear to be used anywhere. I removed it and the related posts section still works.
There was a problem hiding this comment.
It definitely wasn't me who added that ;) (OK it was, I admit it)
gemfarmer
changed the title
gemfarmer
changed the title
coreycaitlin
changed the title
|
|
||
| module Jekyll | ||
| module Converters | ||
| class Markdown::RedcarpetExt |
There was a problem hiding this comment.
Use nested module/class definitions instead of compact style.
gemfarmer
force-pushed
the
same-headers
branch
from
97c3d21
to
9ca776d
Compare
|
Looks like the tests are failing here because of a post that probably has a new # href now. (That means it's working, I think?) |
|
was this post added today? @gboone |
|
Nope, it's this one. Looks like the ID is |
|
Looking at it! |
| @current_headers | ||
| end | ||
|
|
||
| def self.add(item) |
There was a problem hiding this comment.
Inconsistent indentation detected.
gemfarmer
force-pushed
the
same-headers
branch
from
f7d81c2
to
aa0028f
Compare
| end | ||
| end | ||
|
|
||
| def header(title, level) |
There was a problem hiding this comment.
Method has too many lines. [12/10]
| end | ||
|
|
||
| def self.add(item) | ||
| if @current_headers |
There was a problem hiding this comment.
Use 2 (not 3) spaces for indentation.
gemfarmer
force-pushed
the
same-headers
branch
from
b593bad
to
1412d46
Compare
|
🎉 🎉 |
WIP
Fixes issue(s) #1931
😎 PREVIEW
Changes proposed in this pull request:
RedcarpetExt, which extends Redcarpet, and will allow us to add add block-level custom markdown in the futurerelated_postsandwith_pic_posts/2016-03-18-how-user-archetypes-informed-the-draft-us-web-design-standards.md. View it here/cc @mugizico