this address issue #170 #209
Conversation
* allows a local developer to log-in; * bypasses oauth * see .sample.env * set developer email * set skip_team_check to 'true'
| else | ||
| if team_member? | ||
| create_user(auth_email) | ||
| end |
There was a problem hiding this comment.
Not a blocker for this pull request, but there should probably be an else here.
|
This looks like it will be very helpful! Some TODOs:
Also, as a convention, it's useful to the project team to make the commit and pull request title something more descriptive, like "added a way to bypass authentication." This makes it easier to understand what the actual change was when looking at the commit history. Thanks again! |
|
@afeld would you like tests for this stuff? |
|
@ben-biddington @afeld Hey will add some tests and edit changes. Virtual box overwrote my desktop packages so had to deal with that on Sunday. Should be able to do this evening. |
|
Hi there @ChrisCPO - do you have time to update this? |
|
Voting to close this without merge since it's over a year stale. Can be re-opened if someone wants to take the time to update it. |
|
@jessieay: Agreed |
Fixes issue(s) #170.
Changes proposed in this pull request:
/cc relevant people