This repository has been archived by the owner on Dec 8, 2017. It is now read-only.
Consistent URL hashing; multi-value headers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 2, 2015 17:31
mbland
force-pushed
the
improve-url-and-header-handling
branch
from
ff7e0a8
to
1ddeb61
Compare
added 6 commits
October 3, 2015 18:37
|
OK, 18F/hmacauth#1 is in. I've kept this PR in tight sync with that one. Either of y'all mind taking a peek sometime? |
|
cc: @ccostino |
2 tasks
ccostino
added a commit
that referenced
this pull request
Oct 8, 2015
Consistent URL hashing; multi-value headers
|
Awesome work, thanks @mbland! |
|
Thanks for the review, @ccostino! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintains parity with 18F/hmacauth#1. We should wait for that PR to go in before reviewing/submitting this one (unless you want to check it out for style ahead of time).
cc: @afeld and/or @adelevie, if you've the bandwidth.