Merge pull request #30 from 18F/remove_single_logout_service_from_met…

…adata Remove single logout service from metadata
18F · Apr 21, 2020 · 8d0bedc · 8d0bedc
2 parents ffc25a2 + 9bd2945
commit 8d0bedc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/lib/saml_idp/metadata_builder.rb b/lib/saml_idp/metadata_builder.rb
@@ -33,10 +33,6 @@ def fresh
             entity.IDPSSODescriptor protocolSupportEnumeration: protocol_enumeration do |descriptor|
               build_key_descriptor descriptor
               build_name_id_formats descriptor
-              descriptor.SingleLogoutService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST",
-                Location: single_logout_service_post_location
-              descriptor.SingleLogoutService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect",
-                Location: single_logout_service_post_location
               descriptor.SingleSignOnService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST",
                 Location: single_service_post_location
               descriptor.SingleSignOnService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect",

diff --git a/spec/lib/saml_idp/metadata_builder_spec.rb b/spec/lib/saml_idp/metadata_builder_spec.rb
@@ -2,7 +2,7 @@
 module SamlIdp
   describe MetadataBuilder do
     include CloudhsmMockable
-  
+
     it "has a valid fresh" do
       expect(subject.fresh).not_to be_empty
     end
@@ -33,9 +33,7 @@ module SamlIdp
 
     it "includes logout element" do
       subject.configurator.single_logout_service_post_location = 'https://example.com/saml/logout'
-      expect(subject.fresh).to match(
-        '<SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="https://example.com/saml/logout"/>'
-      )
+      expect(subject.fresh).not_to include('SingleLogoutService')
     end
   end
 end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -13,7 +13,6 @@
 require 'rspec'
 require 'capybara/rspec'
 require 'capybara/rails'
-require 'pry-byebug'
 
 require 'ruby-saml'
 require 'saml_idp'