Split up the RequestALetterController into separate controllers for sending and resending #10858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ending and resending This changes reduces some confusion in the IdV flow. It will need to be made in 3 parts: 1. Adding the new routes with functionality 2. Directing to the new routes 3. Tearing down the old routes This change is here to make sure it all works together while I do the above in separate commits [skip changelog]
|
I meant to open this as a draft. It is not intended to be merged. I'll be opening PRs for the component parts and asking for a review on those once I get this green. |
Comment on lines
39
to
46
| <%= @applicant[:address1] %> | ||
| <br /> | ||
| <% if @applicant[:address2] %> | ||
| <%= @applicant[:address2] %> | ||
| <br /> | ||
| <% end %> | ||
| <%= @applicant[:city] %>, <%= @applicant[:state] %> <%= @applicant[:zipcode] %> | ||
| <br /> |
There was a problem hiding this comment.
we have a shared/_address.html partial, looks like we could use it here if we want?
Suggested change
| <%= @applicant[:address1] %> | |
| <br /> | |
| <% if @applicant[:address2] %> | |
| <%= @applicant[:address2] %> | |
| <br /> | |
| <% end %> | |
| <%= @applicant[:city] %>, <%= @applicant[:state] %> <%= @applicant[:zipcode] %> | |
| <br /> | |
| <%= render partial: 'shared/address', address: @applicant %> | |
| <br /> |
or maybe if we want to not pass the whole applicant
Suggested change
| <%= @applicant[:address1] %> | |
| <br /> | |
| <% if @applicant[:address2] %> | |
| <%= @applicant[:address2] %> | |
| <br /> | |
| <% end %> | |
| <%= @applicant[:city] %>, <%= @applicant[:state] %> <%= @applicant[:zipcode] %> | |
| <br /> | |
| <%= render partial: 'shared/address', address: @applicant.slice(:address1, :address2, :city, :state, :zipcode) %> | |
| <br /> |
There was a problem hiding this comment.
Nice, yeah that looks like a good change
|
I have split these changes up across the following PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes reduces some confusion in the IdV flow. It will need to be made in 3 parts:
This change is here to make sure it all works together while I do the above in separate commits