LG-13820 Redirect from request letter controller when letter send is not available #10945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not availble This commit fixes a bug where the `RequestLetterController` was not respecting `GpoVerifyByMailPolicy#send_letter_available?`. If that method returned false then links would be hidden but users could still visit the controller directly and request letters. This commit adds a before action to fix the issue and adds tests. [skip changelog]
jmhooper
changed the title
matthinz
reviewed
Jul 16, 2024
| @@ -33,7 +34,7 @@ def self.step_info | |||
| action: :index, | |||
| next_steps: [:enter_password], | |||
| preconditions: ->(idv_session:, user:) do | |||
| idv_session.verify_info_step_complete? || user.gpo_verification_pending_profile? | |||
| idv_session.verify_info_step_complete? | |||
There was a problem hiding this comment.
I assume that this is not required here because you're not using the request letter controller any more if you come back in a new session and request a resend?
There was a problem hiding this comment.
Yeah, this should have been removed in #10866
jmhooper
deleted the
jmhooper-do-not-allow-request-letter-controller-when-sends-not-allowed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the
RequestLetterControllerwas not respectingGpoVerifyByMailPolicy#send_letter_available?. If that method returned false then links would be hidden but users could still visit the controller directly and request letters.This commit adds a before action to fix the issue and adds tests.