Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-5951 Document the rest of analytics events #30 #6593

Merged
merged 10 commits into from
Jul 20, 2022
Merged

Conversation

stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Jul 15, 2022

Why: SP_REDIRECT_INITIATED, THROTTLER_RATE_LIMIT_TRIGGERED, TOTP_SETUP_VISIT, TOTP_USER_DISABLED

@stevegsa stevegsa marked this pull request as ready for review July 15, 2022 18:41
app/controllers/idv/gpo_controller.rb Outdated Show resolved Hide resolved
app/controllers/idv/gpo_verify_controller.rb Outdated Show resolved Hide resolved
app/controllers/idv_controller.rb Outdated Show resolved Hide resolved
app/controllers/users/verify_personal_key_controller.rb Outdated Show resolved Hide resolved
app/forms/idv/api_image_upload_form.rb Outdated Show resolved Hide resolved
app/forms/register_user_email_form.rb Outdated Show resolved Hide resolved
app/forms/register_user_email_form.rb Outdated Show resolved Hide resolved
app/services/idv/steps/doc_auth_base_step.rb Outdated Show resolved Hide resolved
app/services/idv/steps/send_link_step.rb Outdated Show resolved Hide resolved
end

# Tracks when a user triggered a rate limit throttle
# @param [String] throttle_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we are sending in symbols here, not strings right?

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM almost done with all of these!

@stevegsa stevegsa merged commit 929d868 into main Jul 20, 2022
@stevegsa stevegsa deleted the stevegsa-analytics8 branch July 20, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants