Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Обновление на новый парсер с antlr 4.13.1 #3266

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

theshadowco
Copy link
Member

@theshadowco theshadowco commented Apr 16, 2024

Описание

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

@theshadowco theshadowco added this to the 0.23.0 milestone Apr 16, 2024
Copy link

coderabbitai bot commented Apr 16, 2024

Walkthrough

В этом обновлении были внесены изменения в зависимости и реализацию методов в проекте. Зависимости bsl-parser и bsl-parser-core были обновлены до более новых версий. В файле RewriteMethodParameterDiagnostic.java ссылки на RuleNode были заменены на ParseTree, что изменяет способ доступа и манипуляции узлами при парсинге и анализе кода BSL. Также добавлен новый файл в .gitignore.

Changes

Файл/Путь Описание изменений
.gitignore Добавлен файл /.idea/material_theme_project_new.xml в список игнорируемых файлов
build.gradle.kts Обновлены зависимости: bsl-parser с 0.24.0 на 0.25.0, bsl-parser-core с 0.1.0 на 0.2.0
src/main/java/com/github/.../RewriteMethodParameterDiagnostic.java Заменены ссылки RuleNode на ParseTree в методах, изменены возвращаемые типы

Poem

В коде нашем вновь порядок,
Зависимости обновились в такт.
Узлы парсинга преобразились,
В ParseTree они вместились.
В гитигноре новый путь,
Впереди нас ждет лишь путь! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 16, 2024

Qodana Community for JVM

15 new problems were found

Inspection name Severity Problems
Statement with empty body 🔶 Warning 5
'@Serial' annotation could be used 🔶 Warning 4
Mismatched query and update of collection 🔶 Warning 2
Class is exposed outside of its visibility scope 🔶 Warning 1
Constant values 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Mismatched read and write of array 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

sonarcloud bot commented Apr 16, 2024

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0c111b6 and bc70d67.

Files selected for processing (2)
  • build.gradle.kts (2 hunks)
  • src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3 hunks)
Additional comments not posted (4)
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3)

38-38: Импорт класса ParseTree добавлен в связи с обновлением парсера. Убедитесь, что он используется в коде.

Verification successful

Импорт класса ParseTree действительно используется в коде.

  • Линии кода, где используется ParseTree:
    • .map(ParseTree::getParent)
    • .map(ParseTree::getParent)
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Описание: Проверка использования класса ParseTree в коде.

# Тест: Поиск использования класса ParseTree. Ожидаем: Наличие использования.
rg --type java $'ParseTree' src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java

Length of output: 241


175-175: Изменение метода isVarNameOnlyIntoExpression для использования ParseTree. Убедитесь, что это изменение не влияет на существующую функциональность.


158-158: Обновление метода getRefContextInsideDefAssign для использования ParseTree вместо RuleNode. Проверьте, что новый подход корректно интегрируется с остальной частью кода.

Also applies to: 164-165

build.gradle.kts (1)

77-77: Обновление зависимостей bsl-parser и bsl-parser-core. Убедитесь, что новые версии совместимы с текущим проектом и не вызывают конфликтов.

Also applies to: 87-87

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bc70d67 and 78f6110.

Files selected for processing (2)
  • build.gradle.kts (2 hunks)
  • src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3 hunks)
Additional comments not posted (4)
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (2)

158-165: Изменение одобрено.

Использование ParseTree::getParent вместо RuleNode::getParent повышает гибкость при обработке различных типов узлов разбора.


175-175: Изменение одобрено.

Использование ParseTree::getParent вместо TerminalNode::getParent повышает гибкость при обработке различных типов узлов разбора.

build.gradle.kts (2)

83-83: Обновление зависимости одобрено.

Обновление bsl-parser до версии 0.25.0 вероятно включает исправления ошибок, улучшения производительности и новые функции. Убедитесь, что новая версия совместима с остальной частью проекта.


93-93: Обновление зависимости одобрено.

Обновление bsl-parser-core до версии 0.2.0 вероятно включает исправления ошибок, улучшения производительности и новые функции. Убедитесь, что новая версия совместима с остальной частью проекта.

Copy link

github-actions bot commented Jul 10, 2024

Qodana for JVM

76 new problems were found

Inspection name Severity Problems
Field may be 'final' 🔶 Warning 55
Lombok @Getter may be used 🔶 Warning 11
@NotNull/@Nullable problems 🔶 Warning 5
Stream API call chain can be simplified 🔶 Warning 5

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 101 dependencies

Third-party software list

This page lists the third-party software dependencies used in bsl-language-server

Dependency Version Licenses
aho-corasick-double-array-trie 1.2.2 Apache-2.0
aspectjrt 1.9.22.1 Apache-2.0
checker-qual 3.42.0 MIT
classgraph 4.8.147 MIT
commons-beanutils 1.9.4 Apache-2.0
commons-collections 3.2.2 Apache-2.0
commons-collections4 4.4 Apache-2.0
commons-digester 2.1 Apache-2.0
commons-exec 1.4.0 Apache-2.0
commons-io 2.16.1 Apache-2.0
commons-lang3 3.14.0 Apache-2.0
commons-logging 1.2 Apache-2.0
commons-pool2 2.12.0 Apache-2.0
commons-text 1.10.0 Apache-2.0
commons-validator 1.7 Apache-2.0
english-pos-dict 0.3 LGPL-2.1-only
error_prone_annotations 2.26.1 Apache-2.0
grpc-netty-shaded 1.61.1 Apache-2.0
gson 2.10.1 Apache-2.0
guava 33.2.1-jre Apache-2.0
hunspell 2.1.2 Apache-2.0
istack-commons-runtime 4.1.2 BSD-3-Clause
j2objc-annotations 3.0.0 Apache-2.0
jackson-annotations 2.15.4 Apache-2.0
jackson-core 2.15.4 Apache-2.0
jackson-databind 2.15.4 Apache-2.0
jackson-datatype-jdk8 2.15.4 Apache-2.0
jackson-datatype-jsr310 2.15.4 Apache-2.0
jackson-module-parameter-names 2.15.4 Apache-2.0
jakarta.activation-api 2.1.3 BSD-3-Clause
jakarta.annotation-api 2.1.1 Classpath-exception-2.0
EPL-2.0
GPL-2.0-only
jakarta.websocket-api 2.1.1 Classpath-exception-2.0
EPL-2.0
GPL-2.0-only
jakarta.xml.bind-api 4.0.2 BSD-3-Clause
java-diff-utils 4.12 Apache-2.0
java-sarif 2.0 MIT
javax.activation-api 1.2.0 CDDL-1.1
GPL-2.0-only
javax.annotation-api 1.3.2 CDDL-1.0
GPL-2.0-only
ORACLE-OPENJDK-EXCEPTION-2.0
jaxb-api 2.3.0 CDDL-1.1
GPL-2.0-only
ORACLE-OPENJDK-EXCEPTION-2.0
jaxb-core 4.0.5 BSD-3-Clause
jaxb-runtime 4.0.5 BSD-3-Clause
jgrapht-core 1.5.2 EPL-1.0
LGPL-2.0-or-later
jline-native 3.24.1 BSD-3-Clause
jline-terminal 3.24.1 BSD-3-Clause
jna-platform 5.12.1 Apache-2.0
jna 5.12.1 Apache-2.0
jsr305 3.0.2 Apache-2.0
jul-to-slf4j 2.0.13 MIT
language-detector 0.6 Apache-2.0
language-en 6.4 LGPL-2.0-or-later
language-ru 6.4 LGPL-2.0-or-later
languagetool-core 6.4 LGPL-2.0-or-later
log4j-api 2.21.1 Apache-2.0
log4j-to-slf4j 2.21.1 Apache-2.0
lombok 1.18.32 BSD-3-CLAUSE-NO-TRADEMARK
MIT
lucene-backward-codecs 5.5.5 Apache-2.0
lucene-core 5.5.5 Apache-2.0
micrometer-commons 1.12.5 Apache-2.0
micrometer-core 1.12.5 Apache-2.0
micrometer-observation 1.12.5 Apache-2.0
micrometer-registry-prometheus 1.12.5 Apache-2.0
mxparser 1.2.2 xpp
opennlp-chunk-models 1.5 Apache-2.0
opennlp-postag-models 1.5 Apache-2.0
opennlp-tokenize-models 1.5 Apache-2.0
opennlp-tools 1.9.4 Apache-2.0
openregex 1.1.1 LGPL-2.0-or-later
progressbar 0.10.1 MIT
proto-google-common-protos 2.29.0 Apache-2.0
segment 2.0.1 MIT
simpleclient 0.16.0 Apache-2.0
simpleclient_common 0.16.0 Apache-2.0
simpleclient_guava 0.16.0 Apache-2.0
simpleclient_tracer_common 0.16.0 Apache-2.0
simpleclient_tracer_otel 0.16.0 Apache-2.0
simpleclient_tracer_otel_agent 0.16.0 Apache-2.0
slf4j-api 2.0.13 MIT
snakeyaml 2.2 Apache-2.0
spring-aop 6.1.6 Apache-2.0
spring-beans 6.1.6 Apache-2.0
spring-boot-autoconfigure 3.2.5 Apache-2.0
spring-boot-starter-json 3.2.5 Apache-2.0
spring-boot-starter-logging 3.2.5 Apache-2.0
spring-boot-starter-tomcat 3.2.5 Apache-2.0
spring-boot-starter-web 3.2.5 Apache-2.0
spring-boot-starter-websocket 3.2.5 Apache-2.0
spring-boot-starter 3.2.5 Apache-2.0
spring-boot 3.2.5 Apache-2.0
spring-context 6.1.6 Apache-2.0
spring-core 6.1.6 Apache-2.0
spring-expression 6.1.6 Apache-2.0
spring-jcl 6.1.6 Apache-2.0
spring-messaging 6.1.6 Apache-2.0
spring-web 6.1.6 Apache-2.0
spring-webmvc 6.1.6 Apache-2.0
spring-websocket 6.1.6 Apache-2.0
tomcat-embed-core 10.1.20 Apache-2.0
CDDL-1.0
PROPRIETARY-LICENSE
tomcat-embed-el 10.1.20 Apache-2.0
tomcat-embed-websocket 10.1.20 Apache-2.0
txw2 4.0.5 BSD-3-Clause
vavr-match 0.10.2 Apache-2.0
vavr 0.10.2 Apache-2.0
Contact Qodana team

Contact us at [email protected]

@theshadowco
Copy link
Member Author

/rebase

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 78f6110 and 5e22a78.

Files selected for processing (2)
  • build.gradle.kts (2 hunks)
  • src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java (3 hunks)
Files skipped from review as they are similar to previous changes (2)
  • build.gradle.kts
  • src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/RewriteMethodParameterDiagnostic.java

Copy link

sonarcloud bot commented Jul 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant