adding the hmset with ttl #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump cauldron version in setup.py file |
ghost
suggested changes
Jan 5, 2021
| def hmset_with_ttl(cls,field,value,ttl,namespace =''): | ||
| with (yield from cls.get_pool()) as redis: | ||
| yield from redis.hmset(namespace, field, value) | ||
| redis.expire(namespace,ttl) |
There was a problem hiding this comment.
This will reset the expiry to ttl seconds each time this method is called. So if within "ttl" seconds this method is called again and again the key will never expire. But in our use case key must expire after "ttl" seconds from the time it was first created.
Also, need to check if expire() is a coroutine or not. If it's a coroutine "yield from" is missing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.