Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual cue for overdue headers when displaying headers #970

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dmorlitz
Copy link
Contributor

When you enabled displaying header due dates on the right side of the screen a new visual cue (i.e. 11-29-2023) has been added to clearly identify and separate overdue items from future items.

@@ -0,0 +1,40 @@
GNU nano 6.2 index.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that file was committed accidentally?

'-' +
headerDeadlineMap.get('year')
)
: today;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how you construct this new Date().
When I enter this weird order of arguments in node:

> Date('01-05-2022')
'Wed Nov 29 2023 21:54:27 GMT+0100 (Central European Standard Time)'

I'd suggest to pass a date in ISO format.

@dmorlitz
Copy link
Contributor Author

dmorlitz commented Nov 29, 2023 via email

@schoettl
Copy link
Collaborator

Maybe you can add a screenshot to your PR description above for people to see how it will look.

You can try your JavaScript in the JS console of your browser (just press F12). Try your new Date(...) and see MDN for Date.

Also you would need to use git rebase to remove that invalid file, the nano screen dump.

@dmorlitz
Copy link
Contributor Author

Here is an example of some overdue and some future tasks - when the option to show deadlines on the header line are enabled. The ones surrounded by ** are overdue.
Screenshot_20231129_165538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants