Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Stylelint v15 #11

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Upgrade to Stylelint v15 #11

wants to merge 1 commit into from

Conversation

keichinger
Copy link

This change:

This prevents stylelint from screaming at us whenever we're doing a pnpm update in any of our projects related to the deprecated rules. However, as Stylelint itself writes in their migration guide: The rules were still working fine, they'll just be removed in v16.

I decided to remove all deprecated rules alltogether since the error output looks like this before the actual stylelint-related issues are actually listed, which is significantly way more noise than I prefer:

CleanShot 2023-03-20 at 15 10 55

WDYT @apfelbox @21christiansc

This change:

- requires at least Stylelint v15
- removes all deprecated rules
- enables the new rule `declaration-property-value-no-unknown: true`
@apfelbox
Copy link
Member

Would be great to have a fixer in place, so that we keep the code style lints. What are the options there?

@keichinger
Copy link
Author

I guess we'd need to evaluate something like stylelint-prettier (see https://stackoverflow.com/a/54757106/2690438) and see if it's sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants