backport im services - 4.3 #6402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lazedo
commented
Mar 23, 2020
lazedo
commented
- compatibility with master
lazedo
force-pushed
the
kapi_im
branch
3 times, most recently
from
efd47b0
to
b5b2feb
Compare
| Map#{fetch_id => kapps_im:message_id(IM) | ||
| ,message_id => kapps_im:message_id(IM) | ||
| ,im => IM | ||
| }; | ||
| create_im(Map) -> Map. | ||
|
|
||
| -spec maybe_update_sender(kapps_im:im()) -> kapps_im:im(). | ||
| maybe_update_sender(Im) -> | ||
| case kapps_im:endpoint(Im) of |
There was a problem hiding this comment.
Dialyzer doesn't think undefined will be reached, since the Im record defaults to empty JSON object. Would you prefer to test for empty JObj and return Im unmodified or just bind EP and update the From?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.