Seminar4 #5
Open
Seminar4 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2hyunwoo
approved these changes
Dec 22, 2021
| import com.google.gson.annotations.SerializedName | ||
|
|
||
| data class RequsetLoginData( | ||
| @SerializedName("email") |
There was a problem hiding this comment.
Gson에서는 변수명과 받아오는 데이터의 키가 같으면 SerializedName 안붙이셔도 됩니당~
Comment on lines
+10
to
+14
| data class Data( | ||
| val id: Int, | ||
| val name: String, | ||
| val email: String | ||
| ) |
There was a problem hiding this comment.
Data라는 이름이 좀더 명확했으면 좋겠어. 이건 사람의 정보인 것 같은데 Data는 이걸 포함하고도 한참 넓은 범주인 것 같아
| @POST("user/login") | ||
| fun postLogin( | ||
| @Body body : RequsetLoginData | ||
| ) : retrofit2.Call <ResponseLoginData> |
| .addConverterFactory(GsonConverterFactory.create()) | ||
| .build() | ||
|
|
||
| val service : Service = retrofit.create(Service::class.java) |
There was a problem hiding this comment.
안드로이드 자체에 실제로 Service라는 컴포넌트가 있어서 헷갈리지 않게 작명 유의하면 더 좋을 것 같아요
mdb1217
approved these changes
Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
뒷북,,,,,4차과제,,,,,도착,,,,,,,,,,,