Week7 #5
Open
Week7 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
onpyeong
commented
Dec 10, 2021
•
onpyeong
commented
- 필수과제
- 도전과제
WonJoongLee
reviewed
Dec 17, 2021
Comment on lines
+51
to
+52
| implementation 'androidx.navigation:navigation-fragment-ktx:2.3.5' | ||
| implementation 'androidx.navigation:navigation-ui-ktx:2.3.5' |
There was a problem hiding this comment.
2.4.0-alpha버전부터 백스택 유지가 되는 큰 장점이 있어서 한 번 써보는것도 괜찮을 것 같아!!
Comment on lines
17
to
+31
| <activity | ||
| android:name=".ui.view.user.SignInActivity" | ||
| android:name=".ui.view.setting.SettingActivity" | ||
| android:exported="true" /> | ||
| <activity | ||
| android:name=".ui.view.onboard.OnBoardActivity" | ||
| android:exported="true"> | ||
| <intent-filter> | ||
| <action android:name="android.intent.action.MAIN" /> | ||
|
|
||
| <category android:name="android.intent.category.LAUNCHER" /> | ||
| </intent-filter> | ||
| </activity> | ||
| <activity | ||
| android:name=".ui.view.user.SignInActivity" | ||
| android:exported="true"/> |
There was a problem hiding this comment.
exported="true"는 외부에서 접근할 수 있을 때 true값 주는 것이어서 시작하는 액티비티 빼고는 false로 줘도 될 것 같아!!
Comment on lines
+16
to
+23
| override fun onCreateView( | ||
| inflater: LayoutInflater, container: ViewGroup?, | ||
| savedInstanceState: Bundle? | ||
| ): View { | ||
| super.onCreateView(inflater, container, savedInstanceState) | ||
| setBtnStartClick() | ||
| return binding.root | ||
| } |
There was a problem hiding this comment.
fragment에서 onCreateView 시점은 뷰가 그려지는 중이어서, 뷰가 다 그려진 다음인 onViewCreated()에서 setBtnStartClick() 호출해도 괜찮을 듯!!
Comment on lines
+5
to
+7
| <data> | ||
|
|
||
| </data> |
mdb1217
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.