Fixed Issue #3875 that ProxySetting doesn't support PPPoE connection. Remove unnecessary sysproxy.exe. #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2023 21:29
…tion. Remove sysproxy.exe, which is the unnecessary workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue #3875 that ProxySetting doesn't support PPPoE connection.
Remove sysproxy.exe, which was a workaround to PPPoE problem.
Also fixed memory leaks of StringToHGlobalAuto in SetProxy.
Fixed a couple of warnings.
The code calls RAS API to find out all dial up connections, and change proxy setting for every connection, including LAN.
It also notifies system that proxy setting was changed.
It will throw exceptions with win32 error code when an error occurs. The caller handled the exception and output in logs.
Tested with both LAN and PPPoE connection. I installed a PPPoE server on my openwrt router to validate the change.
ps. please don't embed exe file in the resource, which causes some anti-virus software false alarms.