Skip to content

Commit

Permalink
Bug fix
Browse files Browse the repository at this point in the history
  • Loading branch information
@2dust
2dust committed Jun 29, 2024
1 parent 79297f8 commit a726f00
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions V2rayNG/app/src/main/kotlin/com/v2ray/ang/util/V2rayConfigUtil.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ package com.v2ray.ang.util

import android.content.Context
import android.text.TextUtils
import android.util.Log
import com.google.gson.Gson
import com.tencent.mmkv.MMKV
import com.v2ray.ang.AppConfig
import com.v2ray.ang.AppConfig.ANG_PACKAGE
import com.v2ray.ang.AppConfig.PROTOCOL_FREEDOM
import com.v2ray.ang.AppConfig.TAG_DIRECT
import com.v2ray.ang.AppConfig.TAG_FRAGMENT
Expand Down Expand Up @@ -49,6 +51,12 @@ object V2rayConfigUtil {
return Result(true, customConfig)
}
val outbound = config.getProxyOutbound() ?: return Result(false, "")
val address = outbound.getServerAddress() ?: return Result(false, "")
if (!Utils.isIpAddress(address) && !Utils.isValidUrl(address)) {
Log.d(ANG_PACKAGE, "$address is an invalid ip or domain")
return Result(false, "")
}

val result = getV2rayNonCustomConfig(context, outbound, config.remarks)
//Log.d(ANG_PACKAGE, result.content)
return result
Expand Down

1 comment on commit a726f00

@wangvation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code has a bug when running on my device. The app's logcat prints "D/com.v2ray.ang(10097): xxx.men is an invalid ip or domain". My device OS is Android 10, the app version is 1.8.29, and xxx.men is the domain name of my node (xxx is an alias). After I changed the domain name to xxx.com, the app can connect normally, but xxx.com is not my domain name. And my node can connect normally on the old version of the app.

Please sign in to comment.