-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Setting option to disable internet check. #3486
Comments
@2dust Is this important? If yes then I can make the change and submit a pr, Thanks |
this network check is good for Client usage but I as a config provider, need to test deferent types of configs in deferent operating systems and in android I usually do this locally with JSON input capability of V2rayNG. this Network Checking Feature is not Xray core related and makes these tests harder. with the option to disable this feature, there should be no problem. Plus, not all android devices are smartphones and may result in some unexpected Well, I tried to give my opinion to you guys. Good Luck |
@X-Oracle got your point 👍let's see is he agrees I will just do it 🫶 |
Just remove the feature, there is no need to add an option! Revert #3439 |
okk |
Removed the internet connection check before connecting as per the request in issue 2dust#3486
Removed the internet connection check before connecting as per the request in issue #3486
Hi,
I see in recent commits there is one which forced users to have connected to a network before connecting.
It is good for most cases but when it comes to local connections like local Lan or hotspot. It won't work.
My suggestion is to have an option in settings which we can configure if this check happens or not.
Suggested option name:
Disable Connectivity Check
Behaviour:
Default is Unchecked.
When enabled, the related code should not run when the user hits the start button.
The text was updated successfully, but these errors were encountered: