Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API directory test #8141

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add API directory test #8141

merged 1 commit into from
Jul 30, 2024

Conversation

Carlgo11
Copy link
Member

I made a small test to validate that all the expected API files are present before publishing a build.
That would prevent future #8139-events from happening 😅

@Carlgo11 Carlgo11 added the enhancement Issue/PR contains enhancements to the overall code of the site. label Jul 30, 2024
Copy link
Sponsor Member

@kmpoppe kmpoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also check if the files are reachable via https?

@Carlgo11
Copy link
Member Author

Yes it would, but I have no idea how that could be achieved as the files are only online after the publication workflow is done 😅

@kmpoppe
Copy link
Sponsor Member

kmpoppe commented Jul 30, 2024

Ah i see the problem... Well then, file existence only it is then 😬

@Carlgo11 Carlgo11 merged commit 732594a into 2factorauth:master Jul 30, 2024
2 checks passed
@Carlgo11 Carlgo11 deleted the api-dir-test branch July 30, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR contains enhancements to the overall code of the site.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants