Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sucuri #8193

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add Sucuri #8193

merged 1 commit into from
Sep 9, 2024

Conversation

joshtch
Copy link
Contributor

@joshtch joshtch commented Sep 8, 2024

No description provided.

@Carlgo11
Copy link
Member

Carlgo11 commented Sep 8, 2024

The test seems to be wrong here as the regions array looks fine.

img/s/sucuri.net.svg Outdated Show resolved Hide resolved
entries/s/sucuri.net.json Outdated Show resolved Hide resolved
@fletcherdodd fletcherdodd added the add site Issue/PR adds a site to the repo. label Sep 9, 2024
@fletcherdodd fletcherdodd changed the title Add sucuri.net Add Sucuri Sep 9, 2024
@hkamran80
Copy link
Member

@Carlgo11

The test seems to be wrong here as the regions array looks fine.

The script doesn't know how to handle regions prefixed with a -. I'll submit a PR to fix it.

@Carlgo11
Copy link
Member

Carlgo11 commented Sep 9, 2024

@hkamran80 Already submitted a PR.

@hkamran80
Copy link
Member

@Carlgo11 Probably should've checked my notifications before. Thanks for letting me know!

Region exclusions are based on the information on this page:
https://docs.sucuri.net/billing/do-you-sell-to-my-country/
(Note there are no applicable country code for the excluded regions of
Crimea, Donetsk, or Luhansk.)
@Carlgo11 Carlgo11 marked this pull request as ready for review September 9, 2024 07:09
@Carlgo11 Carlgo11 merged commit 76a5789 into 2factorauth:master Sep 9, 2024
2 checks passed
@joshtch
Copy link
Contributor Author

joshtch commented Sep 9, 2024

I'm really impressed by your efficiency in getting this merged. Thanks!

@joshtch joshtch deleted the patch-1 branch September 9, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add site Issue/PR adds a site to the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants