Add path expansion for files capability #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var phoneDirectoryName = this.fileSystem.Path.GetDirectoryName(phonePath); | ||
| if (phoneDirectoryName == null) | ||
| { | ||
| throw new ArgumentException("phonePath could not be null", "phonePath"); |
There was a problem hiding this comment.
кажется phonePath не может быть null когда речь о файле, но может быть когда речь шла о папке. Ошибка может быть не понятна на фоне всего словаря в capability. Можно же уточнить ошибку информацией из fileInfo?
There was a problem hiding this comment.
Оно никогда не может быть null, т.к. там пустая строка возвращается, если передать только папку. Там null только если на вход подать null
`files` capability now support sending contents of directories, not only files Usage examples: "D:\\preinstalled\\": "", "D:\\preinstalled\\": "downloads", "D:\\preinstalled\\settings.xml": "data\\", "D:\\preinstalled\\settings.xml": "data"
|
@skyline-gleb пачка тесов упала из-за того, что они в одной сессии, которая не смогла подклчиться к приложению из-за того, что хост машина была под высокой нагрузкой от проверок Чапаева |
skyline-gleb
added a commit
that referenced
this pull request
Jan 12, 2016
Add path expansion for files capability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filescapability now support sending contents of directories, not only filesUsage examples:
Fixes #125