Bump hub version to 0.11 #194
Conversation
GeorgianaElena
force-pushed
the
0.11-bump
branch
from
90852e3
to
d7193b7
Compare
Breaking changes to fix: - All authenticator config has changed, and must be modified - jupyterhub/zero-to-jupyterhub-k8s#1943 - pdb has been disabled - we should file an issue to investigate if we want it - jupyterhub/zero-to-jupyterhub-k8s#1938 - Any networkpolicy changes we might need - https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/master/CHANGELOG.md#breaking-changes-1
GeorgianaElena
force-pushed
the
0.11-bump
branch
from
c7dfb8f
to
babfa32
Compare
|
I have tested this on staging and everything appears to be working 🎉 |
hub-templates/base-hub/values.yaml
Outdated
| @@ -75,20 +87,9 @@ jupyterhub: | |||
| limits: | |||
| memory: 1Gi | |||
| https: | |||
| enabled: true | |||
There was a problem hiding this comment.
Would this deploy the autohttps pod? We don't need that, right? I think the letsencrypt section here can also be removed, since we use nginx-ingress + cert-manager for it.
There was a problem hiding this comment.
I think it would yes because letsencrypt.contactEmail is also specified and the default https type is letsencrypt.
With nginx-ingress + cert-manager, set this to false I think.
I'm strongly opinionated after having researched and considered this in depth. I find there is no point enabling a PDB to enforce either 1 replica availability or 0 replica unavailability on pods not supporting having two separate replicas on - this was the old z2jh default. Note also that mybinder.org-deploy has explicitly opted out of the old z2jh default, and systematically avoids having behavior like the old z2jh default for all other deployments with 1 replica. This was discussed in jupyterhub/mybinder.org-deploy#1730 (comment) also. |
|
@consideRatio thanks for the pointers re: pdb. Since this PR blocks #185, I just wanted to try and keep the old behavior as much as possible :) I've opened #202 with your comment, and would love to know how you think we can accomplish the behavior we want. |
|
Thank you @consideRatio and @yuvipanda for feedback <3 |
|
Since this seems to be working on staging, I'm going to merge it now and see what happens 🤞 |
Breaking changes to fix:
modified - add hub.config passthrough and use it for all auth config jupyterhub/zero-to-jupyterhub-k8s#1943
if we want it - Disable PDBs for hub/proxy, add PDB for autohttps, and relocate config proxy.pdb to proxy.chp.pdb jupyterhub/zero-to-jupyterhub-k8s#1938
https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/master/CHANGELOG.md#breaking-changes-1