Set daskNodes = [] if dask isn't specified #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use jinja's templating abilities here, as otherwise we get a `if "daskhub" == "daskhub"` in the jsonnet itself that is a little hard to read
This resolves my point 3 in #2041 (comment) that I was going to ask you about =D Nice!! If this works, this LGTM! |
consideRatio
approved these changes
Jan 23, 2023
GeorgianaElena
approved these changes
Jan 24, 2023
damianavila
approved these changes
Jan 26, 2023
|
I'll go for a merge, this doesn't influence existing hubs and seems right to all of us having reviewed this. |
|
thank you, @consideRatio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use jinja's templating abilities here, as otherwise we get a
if "daskhub" == "daskhub"in the jsonnet itself that is a little hard to read