Deploy some more hub automatically #569
Conversation
|
I thought I had named this branch cp-cd but apparently I was too sleepy to get it right |
|
I'm a bit confused - I though all hubs were auto deployed but maybe that is just for the pilot hubs? It sounds like I need to do another deep dive in the pilot docs since it has been a while and they've changed a lot |
|
@choldgraf Yeah, this repo basically deploys all our hubs now. I opened #570 to rename this repo to clarify. |
Ref 2i2c-org#507 I'm worried that incomplete tests might leave notebook nodes running, but the culler should take care of those? We must verify this. The creds for the carbonplan cluster are from EKS, and I'm not sure how long they are valid for either.
yuvipanda
changed the title
| - requirements.txt | ||
| - dev-requirements.txt | ||
| - config/secrets.yaml | ||
| - config/hubs/carbonplan.cluster.yaml |
There was a problem hiding this comment.
Is handling this "run on changes to a specific cluster.yaml file" the crux of the reason we are using workflow files per cluster rather than one file with a matrix job?
There was a problem hiding this comment.
@sgibson91 It wasn't intentional - i was just following the pattern @GeorgianaElena set up. It is nice to not run them when there's no changes though.
There was a problem hiding this comment.
For sure! I was going to suggest using something like this action to set a conditional on the paths changed https://github.com/dorny/paths-filter
So we maintain the same behaviour of not doing a deploy when nothing's changed, but we can consolidate into a single workflow file and new clusters can just be added to the matrix element list.
There was a problem hiding this comment.
(This shouldn't block the PR btw - merge away and we can open an issue to track this discussion if you like)
Co-authored-by: Sarah Gibson <[email protected]>
There was a problem hiding this comment.
This looks good to me! I had the same thought that @sgibson91 did and I see she opened up #581 so I'm +1 on merging this and tracking that improvement there
|
I've just opened #582 which would replace this PR if merged because it already contains the clusters @yuvipanda was adding in here |
|
Now that #582 has been merged, I think this one can be closed, so closing this but please reopen if I'm wrong! |
Ref #507
I'm worried that incomplete tests might leave notebook
nodes running, but the culler should take care of those? We
must verify this.
Added automatic deployment for everything except farallon
and openscapes hubs - those are using
kopsand I thinktheir kubernetes credentials will have expired. #381
tracks a fix.
Once this is merged, PRs like #580
can be deployed without needing a local setup