SDL metadata strings and save data #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates a file containing the definitions. The library contains some defaults that are marked weak for GCC and relies on the VS linker behavior of OBJs overriding LIBs.
Unused now
So that calling blit_user_code_running returns true
SDL_GetPrefPath already does this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is where my quick save data idea went...
First few commits embed the metadata strings in the SDL build and removes the "CMake!" title completely. (Could replace this with the tool outputting the usual footer as an array to get all the metadata).
Next bit adds
get_save_pathto the API, which returns the path to use for save data.Then we finally get to the thing I was trying to do, with an extra-convenient template wrapper and an example. (Needed to test this anyway)
TODO?: The
.slnbuild isn't broken, but since there's no metadata handling there everything falls back to the defaults...