Fix free space check #475
Merged
Fix free space check #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::strings aren't null-terminated.
|
Haha you've been code golfing your game sizes? 😆 Thank you! I'll tag another release. |
|
Yeah, after shrinking stuff my flash was full of single-block holes. |
|
So, next up is flash-defrag? :) |
|
Haha, think that's quite far down the list! 😄 |
|
Is that also a fix for #470? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must have tested this with a file that fit exactly. Another case of a single character breaking everything...