Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Windows CLI docs #692

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Tweak Windows CLI docs #692

merged 3 commits into from
Jun 22, 2024

Conversation

Gadgetoid
Copy link
Contributor

No description provided.

docs/Windows.md Outdated
- [Troubleshooting](#troubleshooting)
- [Multiple definition of `cleanup_glue`, `_reclaim_reent` etc](#multiple-definition-of-cleanup_glue-_reclaim_reent-etc)

To build using Visual Studio [see here](Windows-VisualStudio.md). The rest of these instructions cover command-line builds.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I had that after the prerequisites section because the VS docs don't mention installing python/the 32blit tools (and git?).

docs/Windows.md Outdated

### Multiple definition of `cleanup_glue`, `_reclaim_reent` etc

If you're building *for* 32blit using the ARM GCC toolchain, and it fails with a wall of text full of multiple definition errors, you've probably installed GCC 10. You should use the `gcc-arm-none-eabi-9-2020-q2-update-win32.exe` package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, using 10.3.1 works fine

Copy link
Collaborator

@Daft-Freak Daft-Freak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out with up-to-date VS 2022. Mostly worked out.

docs/Windows.md Outdated
"snapOnInput": true,
"startingDirectory": "%USERPROFILE%"
}
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used

            {       
                "commandline": "cmd.exe /k \"C://Program Files (x86)//Microsoft Visual Studio//2022//BuildTools//Common7//Tools//VsDevCmd.bat\"",
                "guid": "{5ee0706e-b015-46b2-98a3-2122a8e627d3}",
                "name": "Developer Command Prompt for VS2022",
                "startingDirectory": "%USERPROFILE%"
            }

for VS 2022 build tools. (Couldn't find anything to use as an icon and the rest seems optional)

docs/Windows.md Outdated
```
py -m pip install 32blit
pip install 32blit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My python install (3.10.2) doesn't seem to have pip (or python) only py.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still true, should drop this change too...
snakes


If you want to run code on 32Blit, you should now refer to [Building & Running On 32Blit](32blit.md). You will need to add `-G"NMake Makefiles"` to your cmake commands and use `nmake` instead of `make`. For example:
```
mkdir build.stm32
cd build.stm32
cmake -G"NMake Makefiles" -DCMAKE_TOOLCHAIN_FILE=../32blit.toolchain ..
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMake we get from VS should be new enough for
cmake -B build.stm32 -G"NMake Makefiles" -DCMAKE_TOOLCHAIN_FILE=./32blit.toolchain
instead of this block.

(and then cmake --build build.stm32 [...])

... but I guess If we're doing that we should update other places too...

docs/Windows.md Outdated

### Multiple definition of `cleanup_glue`, `_reclaim_reent` etc

If you're building *for* 32blit using the ARM GCC toolchain, and it fails with a wall of text full of multiple definition errors, you've probably installed GCC 10. You should use the `gcc-arm-none-eabi-9-2020-q2-update-win32.exe` package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, using 10.3.1 works fine

@Daft-Freak
Copy link
Collaborator

Dropped the windows terminal (developer cmd prompt seems to be there by default now) and arm toolchain troubleshooting (fixed) parts.

We definitely don't use C++/CLI
You still need to read as far as installing the tools
@Daft-Freak Daft-Freak merged commit b09918a into master Jun 22, 2024
18 checks passed
@Daft-Freak Daft-Freak deleted the patch-windows-cli-docs branch June 22, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants