Fix GCC 10 #720
Merged
Fix GCC 10 #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GCC 10 Arm toolchain was generating multiple definition errors due to linking both libc and libc_nano, despite using `-nodefailtlibs -lc_nano`. It seems that the `/DISCARD/` section on the linker script was actually causing the "other" libc to be linked in...
That no doubt took forever to actually track down. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, that was easy. There's still some bits in the docs that specify GCC 9, but that's still what's being tested by the actions so I left it.
I've tested this with the official 10.3-2021.07 and 10-2020-q4-major toolchains and it fixes the linker errors there.
(I was expecting this to be some big incompatibility/obscure corner case with the PIC libs... but nope, it's a five character fix...)