Blit function consistency shuffle #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: (stretch_)blit_sprite: takes a transform, always uses Surface::sprites (stretch_)blit: can pass any surface, no transforms (except blit has a hflip) Now there are transform/non transform overloads for each and both take a surface. The `sprite` functions all work as before and there are wrappers for compatibility. (I have no idea if much other than shmup uses "blit with hflip")
Avoids overload ambiguity (SpriteTransform is an int enum).
The one user of one of the three deprecated functions in all the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hopefully just some cleanup of
Surfacemethods. It replaces(stretch_)blit_spritewith new(stretch_)blitoverloads that take a surface/transform and removes the optionalhflipparam fromblit()(the new overloads allow a full transform).There are deprecated wrappers to avoid breaking old code, though only one of the three functions was used in one example... and there only seems to be one repo on GitHub that uses the sprite blit functions directly (DANG).