Firmware tidying #748
Merged
Firmware tidying #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might help with the buggy toggling. Doesn't make it worse at least.
It hasn't done anything for nearly two years and CDC still works so...
It doesn't exist
... and update the comment. I have no idea if this code still works as it's been unused for... years?
Sources were 32blit/32blit_blah, headers were just 32blit_blah. Move both to 32blit/blah
It was relying on 32blit.hpp including it indirectly
That should handle the "not too often" TODO... not that I can test this on my beta blits...
Namespace it like the other stuff
I missed these when I deleted the code that used them in 38c8d4f
|
uh oh this... seems to have exploded into a state of merged/unmerged limbo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up looking at the firmware code for something and spotted a bunch of things that annoyed me enough to tidy them up a bit...
There's definitely more stuff that could be tidied up here... (the old execution switching code is probably entirely broken due to being untested for over a year, display SPI code is only used by a function that is commented out)