Clean up the Emscripten SDL flags space hacks #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by not using any spaces at all
|
I uh, think this may be more than a cleanup for newer Emscripten versions. (I was about to try and fix those... except they're already fixed by this. The script is just using the last release... ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by not using any spaces at all. I didn't know that
-swithout the space was a thing until recently, so now I'm cleaning this up everywhere...(With new enough Emscripten you don't even need a special case for SDL2 itself as
find_package(SDL2)just works... doesn't apply to _image/_net though)