Update USB device library to v2.6.0 #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Emscripten fail was some temporary build failure, but I can't for the life of me seem to re-run the job! Could you give it a kick, please? |
This release has signigicantly less broken error handling in the MSC code. Update made a bit harder by the _slightly_ modified copy of usbd_msc_scsi.c we have...
... or we'll run out of .data
OK/FAIL were inverted... and the caller only treats negative return values as errors
Daft-Freak
force-pushed
the
usb-device-v2.6.0
branch
from
14f69ad
to
2f319d7
Compare
|
Kick successful 😄 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the version after the one currently in use. Most important thing from the release notes is "Fix multiple error with SCSI commands handling" (It was entirely broken).
Some things were already fixed in our second copy of
usbd_msc_scsi.c, but it wasn't enough and almost any error would make the host think the device was hung.Had to modify the lib a little as they un-consted some data for some reason. Hopefully this hasn't broken something else...