Firmware cleanup #778
Merged
Firmware cleanup #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code hasn't been tested for a long time as the SDK hasn't supported creating an executable including the HAL since e2df144. Also, The HAL build for external flash was removed entirely in 8470dd8. Both changes were included in v0.0.8 (November 2020). It's probably safe to delete by now. (Also, the CDC flash code has only allowed relocatable games since v0.1.0) Reduces firmware size by ~1.5k
Only set to internal flash base since 8470dd8
Only set to QSPI base since 8470dd8
Always 1 since 8470dd8
Unused since 8470dd8
... and use it to remove some magic 0x90000000s
Can't use the new header here (this is C code), but can definitly do better than something that expands to inline assembly
All .blit files should have relocs and the CDC flashing already rejects files that don't
... and shuffle some bits around
A bit nicer than the non-inline HAL ones
Doesn't reduce code size due to LTO being enabled (does have an effect with LTO disabled). Still looks nicer though
Not copying things is good.
... to match get_save_path. Also a few other tweaks
paletted one is unused after merging set_screen_mode[_format], and only the size is used from the other two
There's a bit too much generic ST HAL stuff here... that we don't need
|
Wow! RIP obsolete exe switching! Nice work. It's refreshing to see more and more HAL stuff just disappear 😆 |
|
More small cleanups/space savings. (Ran out of space and slightly forgot about these changes... so found other savings) |
|
Ah does this now fix the ~100 bytes debug build overflow? |
|
Can't remember the exact numbers, but I think this already saved a few kb. 3ddd1e2 itself claims ~1.5k... so yes. |
|
Awesome! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code deleting I did a couple of months ago.